pbacsko commented on code in PR #1052:
URL: https://github.com/apache/yunikorn-k8shim/pull/1052#discussion_r3703569964
##########
pkg/shim/scheduler_test.go:
##########
@@ -248,12 +249,33 @@ func TestAssumePodError(t *testing.T) {
pod1 := createTestPod("root.a", "app0001", "task0001", taskResource)
cluster.AddPod(pod1)
- // expect app to enter Completing state with allocation+ask removed
- err = cluster.waitForApplicationStateInCore("app0001", partitionName,
"Completing")
- assert.NilError(t, err)
- app := cluster.getApplicationFromCore("app0001", partitionName)
- assert.Equal(t, 0, len(app.GetAllRequests()), "asks were not removed
from the application")
- assert.Equal(t, 0, len(app.GetAllAllocations()), "allocations were not
removed from the application")
+ // wait for the application to be registered and its ask queued in the
shim
+ cluster.waitAndAssertApplicationState(t, "app0001",
cache.ApplicationStates().Accepted)
Review Comment:
This change causes the test to be flaky - it keeps appearing on my local
laptop. "Accepted" state is only observable for a bried amount of time.
Sometimes it moves on to "Running" quickly and the part times out.
Just simply remove this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
