pbacsko commented on code in PR #1062:
URL: https://github.com/apache/yunikorn-k8shim/pull/1062#discussion_r3773522819
##########
pkg/cache/task.go:
##########
@@ -39,6 +41,14 @@ import (
"github.com/apache/yunikorn-scheduler-interface/lib/go/si"
)
+// bindPodBackoff controls the retry schedule for binding pod volumes and
binding the
+// pod to a node. Declared as a package variable so tests can shorten it.
+var bindPodBackoff = wait.Backoff{
Review Comment:
I realized if the intention is to cap the total amount of time spent in
backoff is 30s, then this setting is not correct.
Cap suggests a total-time limit; it isn't one. Future readers may add
Factor: 2 thinking total time stays ~30s, but they'd get much longer waits (1s
+ 2s + 4s + … up to 30s per sleep).
If the goal is a hard total deadline, wait.Backoff doesn't provide that
directly. We might as well remove it: from here and from the existing backoff
setting near AssumePod.
##########
pkg/cache/task.go:
##########
@@ -39,6 +41,14 @@ import (
"github.com/apache/yunikorn-scheduler-interface/lib/go/si"
)
+// bindPodBackoff controls the retry schedule for binding pod volumes and
binding the
+// pod to a node. Declared as a package variable so tests can shorten it.
+var bindPodBackoff = wait.Backoff{
Review Comment:
I realized if the intention is to cap the total amount of time spent in
backoff, then this setting is not correct.
Cap suggests a total-time limit; it isn't one. Future readers may add
Factor: 2 thinking total time stays ~30s, but they'd get much longer waits (1s
+ 2s + 4s + … up to 30s per sleep).
If the goal is a hard total deadline, wait.Backoff doesn't provide that
directly. We might as well remove it: from here and from the existing backoff
setting near AssumePod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
