kaijaytu commented on code in PR #236:
URL: https://github.com/apache/yunikorn-release/pull/236#discussion_r3802801236
##########
perf-tools/utils/table.go:
##########
@@ -46,9 +47,13 @@ func (t *Table) Output(file string) error {
}
func (t *Table) render(writer *tablewriter.Table) {
Review Comment:
Thanks for the review! Addressed in fixup e2440ae:
- render() now returns error
- Print() logs via Logger.Error("failed to render table to stdout",
zap.Error(err)) (satisfies errcheck)
- Output() returns the error from render() and adds defer f.Close() (also
fixes a pre-existing FD leak on the render path)
Verified locally: make test_all -- lint reports 0 issues. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
