PoiBlackTea opened a new pull request, #1133:
URL: https://github.com/apache/yunikorn-core/pull/1133
### Description
Fixes a goroutine and resource leak in `EventStreaming.CreateEventStream`
identified during the review of #1124. Previously, replaying historical events
used a bare blocking send (`consumer <- event`) outside the forwarder's
`select` loop. If a client requested non-zero history and disconnected early
(or history exceeded the 1,000-element channel buffer), the send blocked
indefinitely because neither `stop` nor `e.stopCh` could be reached.
This PR makes the history-replay send selectable, allowing the forwarder
goroutine to exit promptly upon stream removal or system shutdown.
### Type of change
Please delete options that are not relevant.
- [X] Bug Fix
- [ ] Improvement
- [ ] Feature
- [ ] Refactoring
- [ ] Documentation
### Jira issue
Jira ID : https://issues.apache.org/jira/browse/YUNIKORN-3364
- [ ] I have created a Jira issue for this pull request.
- [X] The Jira ID is part of the title of this pull request.
### AI Tooling
If an AI tool was used:
- [X] The PR includes the phrase "Generated by Antigravity CLI", where
Antigravity CLI is the name of the AI tool used.
- [X] My use of AI contributions follows the ASF legal policy.
Check https://www.apache.org/legal/generative-tooling.html for details.
### How has this been tested?
- [ ] New unit tests were added to cover new or changed code paths.
- [ ] `make test_all` was run, and no failures reported.
- [ ] A pull request will be opened for new e2e tests
(apache/yunikorn-k8shim repository).
### Questions:
- [ ] The change needs documentation, a pull request for
apache/yunikorn-site repository will be created.
- [ ] There is breaking changes for older versions: jira is tagged with
`release-notes` label.
- [ ] The licenses files needs to be updated.
### Screenshots or other details
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
