chenyulin0719 commented on code in PR #1133:
URL: https://github.com/apache/yunikorn-core/pull/1133#discussion_r3864929188
##########
pkg/events/event_streaming.go:
##########
Review Comment:
Another go leak found in Line 135 when running
TestEventStreaming_SlowConsumer. (Add goroutine leak detection)
go test ./pkg/events/... -run '^TestEventStreaming_SlowConsumer$' -count=1 -v
```
--- PASS: TestCreateEventRecordTypes (0.00s)
PASS
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 90 in state chan send, with
github.com/apache/yunikorn-core/pkg/events.(*EventStreaming).CreateEventStream.func1
on top of the stack:
github.com/apache/yunikorn-core/pkg/events.(*EventStreaming).CreateEventStream.func1(0x39595544d880,
0x39595544d8f0, 0x395955478540)
/home/chenyulin0719/yunikorn/yunikorn-core/pkg/events/event_streaming.go:135
+0x2c5
created by
github.com/apache/yunikorn-core/pkg/events.(*EventStreaming).CreateEventStream
in goroutine 89
/home/chenyulin0719/yunikorn/yunikorn-core/pkg/events/event_streaming.go:100
+0x218
]
FAIL github.com/apache/yunikorn-core/pkg/events 0.511s
? github.com/apache/yunikorn-core/pkg/events/mock [no test files]
FAIL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
