tigerquoll commented on code in PR #1060:
URL: https://github.com/apache/yunikorn-k8shim/pull/1060#discussion_r3895186780
##########
pkg/conf/schedulerconf.go:
##########
@@ -97,7 +98,14 @@ const (
DefaultKubeBurst = -1
DefaultKubeEventQPS = 200 // events are discardable
and limited by default: <= 0 means no limiter
DefaultKubeEventBurst = 400
+ DefaultKubeEventLevel = EventLevelNormal
DefaultAMFilteringGenerateUniqueAppIds = false
+
+ // event levels, the value of CMKubeEventLevel: all events, the Warning
events only, or
+ // no events at all
+ EventLevelNormal = "normal"
+ EventLevelWarning = "warning"
+ EventLevelNone = "none"
Review Comment:
Correct, Kubernetes only has `Normal` and `Warning` (`v1.EventTypeNormal` /
`v1.EventTypeWarning`); `none` was borrowed from the audit policy levels and
does not belong here. Dropped: `kubernetes.eventLevel` is now `normal` |
`warning`, mirroring the two event types, and any other value falls back to
`normal` with a warning in the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
