manirajv06 commented on code in PR #1060:
URL: https://github.com/apache/yunikorn-k8shim/pull/1060#discussion_r3893029437
##########
pkg/cache/context.go:
##########
@@ -1249,7 +1249,7 @@ func (ctx *Context) HandleContainerStateUpdate(request
*si.UpdateContainerSchedu
Message: request.Reason,
}) {
events.GetRecorder().Eventf(task.GetTaskPod().DeepCopy(), nil,
- v1.EventTypeNormal, "PodUnschedulable",
"PodUnschedulable",
+ v1.EventTypeWarning,
"PodUnschedulable", "PodUnschedulable",
Review Comment:
Can we do cross check to ensure correct event type has been used across all
places?
For ex, task#beforeTaskFail uses normal.
##########
pkg/conf/schedulerconf.go:
##########
@@ -97,7 +98,14 @@ const (
DefaultKubeBurst = -1
DefaultKubeEventQPS = 200 // events are discardable
and limited by default: <= 0 means no limiter
DefaultKubeEventBurst = 400
+ DefaultKubeEventLevel = EventLevelNormal
DefaultAMFilteringGenerateUniqueAppIds = false
+
+ // event levels, the value of CMKubeEventLevel: all events, the Warning
events only, or
+ // no events at all
+ EventLevelNormal = "normal"
+ EventLevelWarning = "warning"
+ EventLevelNone = "none"
Review Comment:
Does K8s has "none" level? I can see only the first two. 1. Normal 2.
Warning. Do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
