matthias-koch commented on code in PR #4691:
URL: https://github.com/apache/zeppelin/pull/4691#discussion_r1395688313
##########
rlang/pom.xml:
##########
@@ -116,18 +116,10 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-client</artifactId>
+ <artifactId>hadoop-client-runtime</artifactId>
<version>${hadoop.version}</version>
<scope>compile</scope>
</dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-common</artifactId>
- <version>${hadoop.version}</version>
- <scope>compile</scope>
- </dependency>
-
<dependency>
Review Comment:
The description at
https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html says:
> Requires dependency resolution of artifacts in scope: runtime
But I am really not sure, how all dependencies are resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
