pan3793 commented on code in PR #4691:
URL: https://github.com/apache/zeppelin/pull/4691#discussion_r1405856658
##########
rlang/pom.xml:
##########
@@ -116,18 +116,10 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-client</artifactId>
+ <artifactId>hadoop-client-runtime</artifactId>
<version>${hadoop.version}</version>
<scope>compile</scope>
</dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-common</artifactId>
- <version>${hadoop.version}</version>
- <scope>compile</scope>
- </dependency>
-
<dependency>
Review Comment:
> As far as I understand it correctly, YARN has already loaded the Hadoop
dependencies and therefore they don't need to be in Zeppelin additionally.
There is a switch in YARN to enable/disable Hadoop class population in the
containers.
> we should make sure that we do not deliver the library more than once
QQ, I understand we should not include Hadoop classes in plugins, because
they will be loaded into the same JVM with Zeppelin server, so that they can
share the Hadoop classes. What about the interpreteres? I assume the
interpreters are always run in dedicated JVMs, so Hadoop classes seem always
necessary (except for those runtimes who already provided Hadoop classes, e.g.
Spark, Flink)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
