tbonelee commented on code in PR #4780:
URL: https://github.com/apache/zeppelin/pull/4780#discussion_r1703178904
##########
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##########
@@ -190,7 +192,7 @@ public void start(String userName) throws IOException {
// check if the interpreter process exit script
// if interpreter process exit, then container need exit
StringBuilder sbStartCmd = new StringBuilder();
- sbStartCmd.append("sleep 10; ");
+ sbStartCmd.append("sleep 20; ");
Review Comment:
For Docker mode, there might be a way to actively execute the process
instead of just waiting.
However, in this case, we may have chosen this structure to upload
interpreter files by using commands like `rm`, `mkdir`, while the container is
running, and then execute the `interpreter.sh`.
I will consider whether we can change this structure.
##########
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##########
@@ -190,7 +192,7 @@ public void start(String userName) throws IOException {
// check if the interpreter process exit script
// if interpreter process exit, then container need exit
StringBuilder sbStartCmd = new StringBuilder();
- sbStartCmd.append("sleep 10; ");
+ sbStartCmd.append("sleep 20; ");
Review Comment:
For Docker mode, there might be a way to actively execute the process
instead of just waiting.
However, in this case, we may have chosen this structure to upload
interpreter files by using commands like `rm`, `mkdir`, while the container is
running, and then execute the `interpreter.sh`.
I will consider whether we can change this structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
