pan3793 commented on code in PR #4780: URL: https://github.com/apache/zeppelin/pull/4780#discussion_r1717049304
########## scripts/docker/interpreter/Dockerfile: ########## @@ -13,22 +13,24 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM apache/zeppelin:0.8.0 +FROM apache/zeppelin:0.11.2-SNAPSHOT MAINTAINER Apache Software Foundation <[email protected]> -ENV SPARK_VERSION=2.3.3 -ENV HADOOP_VERSION=2.7 +ENV SPARK_VERSION=3.5.1 +ENV HADOOP_VERSION=3 Review Comment: is this Dockerfile supposed to be used by user? if so, we should use ARG instead of ENV. additionally, it's better to change it to SPARK_NAME or something else because the official spark binary artifacts have the below suffix ``` -hadoop2 (removed since 3.4.0) -hadoop3 -without-hadoop ``` users are also allowed to `dev/make-distribution.sh --name custom` to create spark bin tarball with `-custom` suffix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
