Reamer commented on code in PR #5006:
URL: https://github.com/apache/zeppelin/pull/5006#discussion_r2289960862
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java:
##########
@@ -359,11 +359,11 @@ private void prepareSource(HeliumPackage pkg, String[]
moduleNameVersion,
.append(" from \"../" + mainFileName + "\"\n");
loadJsRegister.append(HELIUM_BUNDLES_VAR + ".push({\n");
- loadJsRegister.append("id: \"" + moduleNameVersion[0] + "\",\n");
- loadJsRegister.append("name: \"" + pkg.getName() + "\",\n");
- loadJsRegister.append("icon: " + gson.toJson(pkg.getIcon()) + ",\n");
- loadJsRegister.append("type: \"" + pkg.getType() + "\",\n");
- loadJsRegister.append("class: " + className + "\n");
+ loadJsRegister.append(" id: \"" + moduleNameVersion[0] + "\",\n");
Review Comment:
My suggestion is to use the following style so that no string concatenation
is performed.
```suggestion
loadJsRegister.append(idention).append("id:
\"").append(moduleNameVersion[0]).apend("\",\n");
```
Of course, the idention variable must be defined before, but it also makes
it easier to change it globally. It also makes the code more readable,
explaining why two spaces are inserted. I don't think these are necessary from
a purely programmatic point of view, do they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
