tbonelee commented on code in PR #5006:
URL: https://github.com/apache/zeppelin/pull/5006#discussion_r2291101118
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java:
##########
@@ -359,11 +359,11 @@ private void prepareSource(HeliumPackage pkg, String[]
moduleNameVersion,
.append(" from \"../" + mainFileName + "\"\n");
loadJsRegister.append(HELIUM_BUNDLES_VAR + ".push({\n");
- loadJsRegister.append("id: \"" + moduleNameVersion[0] + "\",\n");
- loadJsRegister.append("name: \"" + pkg.getName() + "\",\n");
- loadJsRegister.append("icon: " + gson.toJson(pkg.getIcon()) + ",\n");
- loadJsRegister.append("type: \"" + pkg.getType() + "\",\n");
- loadJsRegister.append("class: " + className + "\n");
+ loadJsRegister.append(" id: \"" + moduleNameVersion[0] + "\",\n");
Review Comment:
Thanks for pointing that out. I've removed the indentation (as it didn't
really improve readability) and replaced the string concatenation with
`.append()`, following your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
