dididy commented on PR #5054: URL: https://github.com/apache/zeppelin/pull/5054#issuecomment-3245989283
Due to IDE autocomplete, an incorrect parameter was passed to the `-p` option, and some mistakes occurred while making corrections based on that. Thanks again for the thorough review. I have removed `linterOptions.exclude` from `tslint.json`, and also removed the `-p` option when running tslint. (After removing the option, I confirmed that lint works correctly based on `tslint.json`.) I looked into managing `tslint-rules` in a monorepo style by adding settings in Angular’s `angular.json` for **ng**, but it turned out to be somewhat Angular-dependent, and the tslint-rules don’t have enough volume to justify being structured as a separate repository. While using `@nrwl/workspace:run-commands`([build example](https://github.com/3Shain/kairo/blob/1283229ef5f9fcf82ce7336c361b89669680c82a/angular.json#L235)) would allow the desired command(tsc build) to run directly, it requires installing a separate package(@nrwl/workspace), the minimum Angular version is 20. Therefore, `tslint-rules` is handled separately during linting in package.json, and its scope is also separated in `lint-staged`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
