dididy opened a new pull request, #5054:
URL: https://github.com/apache/zeppelin/pull/5054

   ### What is this PR for?
   In `npm run lint`, `projects folder` both are linted using ng, but 
`prettier` only checks the `src folder`. In `lint-staged`, neither lint nor 
`prettier` checks the `projects folder`. This seems to need fixing.
   
   Because `ng lint --fix` is not supported, I added a `lint:fix` script to run 
`tslint` with the `--fix` option. 
   
   Since src and projects folders need to reference different tslint configs, I 
added the corresponding option to lint-staged.
   
   ### What type of PR is it?
   
   Bug Fix
   Improvement
   
   ### Todos
   
   ### What is the Jira issue?
   * [[ZEPPELIN-6301](https://issues.apache.org/jira/browse/ZEPPELIN-6301)]
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the license files need to update? N
   * Is there breaking changes for older versions? N
   * Does this needs documentation? N


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to