dididy commented on PR #5044:
URL: https://github.com/apache/zeppelin/pull/5044#issuecomment-3254029484
c90cd09
- Made `notebookParagraphCodeEditorComponent` optional.
5e35dbf
- Added a comment for `editorSettingTriggerAllowed`.
6c993a0
- There are two related actions: `CLONE_PARAGRAPH` and `INSERT_PARAGRAPH`.
Each needs to be handled slightly differently.
#### Behavior
- **CLONE_PARAGRAPH**
1. `send > CLONE_PARAGRAPH`
2. `receive > PARAGRAPH_ADDED → PARAGRAPH → trigger EDITOR_SETTING`
- **INSERT_PARAGRAPH**
1. `send > INSERT_PARAGRAPH`
2. `receive > trigger EDITOR_SETTING` **after** `PARAGRAPH_ADDED`
#### Implementation
- `CLONE_PARAGRAPH` was already handled correctly.
- For `INSERT_PARAGRAPH`, we added:
- A variable `isTriggeredByInsertParagraph` in `notebook.component.ts`.
- Set it to `true` when `insertParagraph` in `paragraph.component.ts` is
executed.
- This allows branching based on whether `PARAGRAPH_ADDED` was triggered by
an `INSERT_PARAGRAPH` or a `CLONE_PARAGRAPH`.
#### Reasoning
- `CLONE_PARAGRAPH`: `EDITOR_SETTING` runs **after receiving PARAGRAPH**.
- `INSERT_PARAGRAPH`: `EDITOR_SETTING` runs **when `PARAGRAPH_ADDED` is
received**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
