dididy commented on code in PR #5044:
URL: https://github.com/apache/zeppelin/pull/5044#discussion_r2322426811
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts:
##########
@@ -109,6 +109,10 @@ export class NotebookComponent extends
MessageListenersManager implements OnInit
@MessageListener(OP.INTERPRETER_BINDINGS)
loadInterpreterBindings(data:
MessageReceiveDataTypeMap[OP.INTERPRETER_BINDINGS]) {
+ this.listOfNotebookParagraphComponent.forEach(item => {
+ item.notebookParagraphCodeEditorComponent.editorSettingTriggerAllowed =
true;
Review Comment:
c90cd09
In testing, the interpreter setting works correctly when
`this.setParagraphMode(true)` is executed inside
`editor.onDidChangeModelContent()`.
Since this runs **before** the code that executes when receiving
`INTERPRETER_BINDINGS` above (`editor.onDidChangeModelContent()`), the code
that runs after `editorSettingTriggerAllowed = true` was modified to directly
call `getEditorSetting()` instead of using `setParagraphMode(true)` when
receive `PARAGRAPH` or `INTERPRETER_BINDINGS`. Because if the interpreter is
already set inside `this.setParagraphMode(true)`, `getEditorSetting()` will not
be executed due to the condition, and since `setParagraphMode(true)` has
already run, there is no need to execute it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
