dididy commented on code in PR #5075:
URL: https://github.com/apache/zeppelin/pull/5075#discussion_r2356145927
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.html:
##########
@@ -40,26 +40,27 @@
[colWidthOption]="colWidthOption"
[pid]="paragraph.id"
[isEntireNoteRunning]="isEntireNoteRunning"
- [(enabled)]="paragraph.config.enabled"
- [(tableHide)]="paragraph.config.tableHide"
- [(colWidth)]="paragraph.config.colWidth"
- [(title)]="paragraph.config.title"
- [(fontSize)]="paragraph.config.fontSize"
- [(lineNumbers)]="paragraph.config.lineNumbers"
- [(editorHide)]="paragraph.config.editorHide"
- [(runOnSelectionChange)]="paragraph.config.runOnSelectionChange"
- (tableHideChange)="commitParagraph()"
+ [enabled]="paragraph.config.enabled"
+ [tableHide]="paragraph.config.tableHide"
+ [colWidth]="paragraph.config.colWidth"
+ [titleShow]="paragraph.config.title"
+ [fontSize]="paragraph.config.fontSize"
+ [showLineNumbers]="paragraph.config.lineNumbers"
+ [editorHide]="paragraph.config.editorHide"
+ [runOnSelectionChange]="paragraph.config.runOnSelectionChange"
Review Comment:
That’s true, but even if `paragraph` is non-null, `config` or `title` are
optional, so they might not exist. Typically, the template type check does not
enforce the attribute types when the parent is non-null, and since the current
type check passes fine, this can probably be ignored.
https://github.com/apache/zeppelin/pull/5075/files#diff-487607158ec7cd3af649d3a9a23b74fec125bda0bde28ac52c089fbf001bda19L72
Following up on the [comment
link](https://github.com/apache/zeppelin/pull/5075/files#diff-b51f1242e607c0c7567f1b1d0667919f687bd0ef86a65ce9be1d5a58768882bbR22-R24)
I left earlier, I noticed that `id` is being treated as non-null here, which
also feels a bit strange. Looking at
`published/paragraph/paragraph.component.ts`, it receives `OP.NOTE`. After
receiving it, it makes sense logically to find the paragraph whose ID matches
the current URL before performing any actions. Therefore, if
`zeppelin-notebook-paragraph` is also handled with `*ngIf` so that it only
operates when the paragraph exists, then treating it as non-null becomes
meaningful.
In the case of `PublishedParagraphComponent`, this refers to the screen
displayed when accessing a link generated via “Link this paragraph.”
Previously, I observed that if I access the link without the paragraph being
executed, the results do not appear, leaving a blank screen until the paragraph
is actually run, which seems awkward. I previously raised an issue about this
([ZEPPELIN-6324](https://issues.apache.org/jira/browse/ZEPPELIN-6324)). I’m
currently working on modifying this part.
If a user accesses shared link that paragraph does not exist, it seems more
correct to redirect to the home screen and display an error modal indicating
that the paragraph does not exist. If you agree, I'll create a new issue for
this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
