dididy commented on code in PR #5075:
URL: https://github.com/apache/zeppelin/pull/5075#discussion_r2357451014
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.html:
##########
@@ -40,26 +40,27 @@
[colWidthOption]="colWidthOption"
[pid]="paragraph.id"
[isEntireNoteRunning]="isEntireNoteRunning"
- [(enabled)]="paragraph.config.enabled"
- [(tableHide)]="paragraph.config.tableHide"
- [(colWidth)]="paragraph.config.colWidth"
- [(title)]="paragraph.config.title"
- [(fontSize)]="paragraph.config.fontSize"
- [(lineNumbers)]="paragraph.config.lineNumbers"
- [(editorHide)]="paragraph.config.editorHide"
- [(runOnSelectionChange)]="paragraph.config.runOnSelectionChange"
- (tableHideChange)="commitParagraph()"
+ [enabled]="paragraph.config.enabled"
+ [tableHide]="paragraph.config.tableHide"
+ [colWidth]="paragraph.config.colWidth"
+ [titleShow]="paragraph.config.title"
+ [fontSize]="paragraph.config.fontSize"
+ [showLineNumbers]="paragraph.config.lineNumbers"
+ [editorHide]="paragraph.config.editorHide"
+ [runOnSelectionChange]="paragraph.config.runOnSelectionChange"
Review Comment:
> For the
`PublishsedParagraphComponent`(`published/paragraph/paragraph.html`), it makes
sense to render `zeppelin-notebook-paragraph-result` only when `paragraph` is
defined. I've updated it so that it's rendered conditionally.
I’ve reviewed it and can confirm. Thank you.
> Additionally, regarding the automatic run for "Link this paragraph", how
about showing a confirmation message so that users can decide whether to run
the selected paragraph if it hasn'been executed yet? In some notebooks, running
paragraphs might cause side effects on external databases, so I think it would
be better to ask the user before executing. What do you think?
That’s a great idea. I’ll add a comment about this to the issue. Thanks for
the valuable suggestion.
Also, I plan to have this process run only when the result doesn’t exist.
> I agree that it makes sense to handle cases where a paragraph does not
exist on the published page.
Okay I'll add this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
