tbonelee commented on code in PR #5072:
URL: https://github.com/apache/zeppelin/pull/5072#discussion_r2359307869


##########
.github/workflows/frontend.yml:
##########


Review Comment:
   I've been thinking a bit about the test job.
   How about adding the newly introduced test job to 
`zeppelin-web-angular/pom.xml` so that it runs during the Mavent test phase, 
just like the other jobs, and then referenceing it here in GitHub actions?
   
   Although developers will usually run E2E tests locally through npm scripts, 
if we integrate this into the Maven phase, it would allow all tests to run 
together whenever the Maven test phase is executed. That way, the tests could 
be managed in a more unified manner.
   I think we can refer to `zeppelin-web/pom.xml`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to