dididy commented on code in PR #5072:
URL: https://github.com/apache/zeppelin/pull/5072#discussion_r2359599735
##########
zeppelin-web-angular/package.json:
##########
@@ -12,10 +12,16 @@
"build-project:sdk": " ng build --project zeppelin-sdk",
"build-project:vis": " ng build --project zeppelin-visualization",
"build-project:helium": "ng build --project zeppelin-helium",
- "test": "ng test",
"lint": "ng lint && tslint -p tslint-rules/tsconfig.json && prettier
--check \"**/*.{ts,js,json,css,html}\"",
"lint:fix": "ng lint --fix && tslint --fix -p tslint-rules/tsconfig.json
&& prettier --write \"**/*.{ts,js,json,css,html}\"",
- "e2e": "ng e2e"
+ "e2e": "playwright test",
+ "e2e:fast": "playwright test --project=chromium",
+ "e2e:ui": "playwright test --ui",
+ "e2e:headed": "playwright test --headed",
+ "e2e:debug": "playwright test --debug",
+ "e2e:report": "playwright show-report",
+ "e2e:ci": "export CI=true && playwright test",
+ "e2e:codegen": "npm run start || playwright codegen http://localhost:4200";
Review Comment:
fcc9b57
It’s not a critical part, but installing a new dependency feels a bit
awkward, and there’s also a nuance that codegen itself assumes a local server
is already running. So I went with Henry-Hong’s suggestion and removed the part
before the or operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
