dididy commented on code in PR #5109:
URL: https://github.com/apache/zeppelin/pull/5109#discussion_r2454652343
##########
zeppelin-web-angular/projects/zeppelin-visualization/.eslintrc.json:
##########
@@ -0,0 +1,38 @@
+{
+ "extends": "../../.eslintrc.json",
+ "ignorePatterns": ["!**/*"],
+ "overrides": [
+ {
+ "files": ["*.ts"],
+ "parserOptions": {
+ "project": [
+ "projects/zeppelin-visualization/tsconfig.lib.json",
+ "projects/zeppelin-visualization/tsconfig.spec.json"
Review Comment:
```suggestion
"zeppelin-web-angular/projects/zeppelin-visualization/tsconfig.lib.json",
"zeppelin-web-angular/projects/zeppelin-visualization/tsconfig.spec.json"
```
<img width="548" height="80" alt="Image"
src="https://github.com/user-attachments/assets/8210d411-02d4-437b-910c-b4478dca819e";
/>
##########
zeppelin-web-angular/projects/zeppelin-sdk/.eslintrc.json:
##########
@@ -0,0 +1,35 @@
+{
+ "extends": "../../.eslintrc.json",
+ "ignorePatterns": ["!**/*"],
+ "overrides": [
+ {
+ "files": ["*.ts"],
+ "parserOptions": {
+ "project": ["projects/zeppelin-sdk/tsconfig.lib.json",
"projects/zeppelin-sdk/tsconfig.spec.json"],
Review Comment:
```suggestion
"project":
["zeppelin-web-angular/projects/zeppelin-sdk/tsconfig.lib.json",
"zeppelin-web-angular/projects/zeppelin-sdk/tsconfig.spec.json"],
```
<img width="637" height="67" alt="Image"
src="https://github.com/user-attachments/assets/be9c53f0-41e6-45eb-a956-a1f53004e411";
/>
##########
zeppelin-web-angular/.browserslistrc:
##########
Review Comment:
It seems that `.browserslistrc` exists in both `zeppelin-web-angular/` and
`zeppelin-web-angular/src/`. Aside from comments, there doesn’t appear to be
any difference between them. So I think it should be fine to keep just one of
them.
##########
zeppelin-web-angular/src/app/pages/workspace/share/result/result.component.ts:
##########
@@ -26,7 +26,7 @@ import {
ViewContainerRef
} from '@angular/core';
import { DomSanitizer, SafeHtml, SafeUrl } from '@angular/platform-browser';
-import { default as AnsiUp } from 'ansi_up';
+import { AnsiUp } from 'ansi_up';
Review Comment:
<img width="387" height="84" alt="Image"
src="https://github.com/user-attachments/assets/e46013de-1924-435a-b184-15ea5632a269";
/>
It seems like type definitions and related setup for **ansi_up** are
required.
##########
zeppelin-web-angular/package.json:
##########
@@ -78,28 +80,31 @@
"@types/node": "~12.19.16",
"@types/parse5": "^5.0.2",
"@types/webpack-env": "^1.18.8",
- "codelyzer": "^5.0.0",
+ "@typescript-eslint/eslint-plugin": "5.27.1",
+ "@typescript-eslint/parser": "5.27.1",
"cross-env": "^10.1.0",
- "dotenv": "^8.0.0",
+ "dotenv": "^17.2.3",
+ "eslint": "^8.17.0",
+ "eslint-config-prettier": "^10.1.8",
+ "eslint-plugin-import": "^2.32.0",
+ "eslint-plugin-jsdoc": "^50.8.0",
+ "eslint-plugin-prefer-arrow": "^1.2.3",
"https-proxy-agent": "^2.2.1",
"husky": "9.1.7",
- "lint-staged": "^8.1.6",
+ "lint-staged": "^15.5.2",
"monaco-editor-webpack-plugin": "6.0.0",
- "ng-packagr": "^9.1.5",
- "ngx-build-plus": "^9.0.6",
- "nz-tslint-rules": "^0.800.2",
- "prettier": "^1.17.0",
- "protractor": "~5.4.0",
+ "ng-packagr": "^13.3.1",
+ "ngx-build-plus": "^13.0.1",
+ "nz-tslint-rules": "^0.901.0",
+ "prettier": "^3.6.2",
"scandirectory": "8.1.1",
"ts-node": "~7.0.0",
- "tsickle": "0.38.1",
- "tslint": "~5.15.0",
"tslint-no-circular-imports": "^0.7.0",
Review Comment:
If we’re removing TSLint, I think we can also remove `nz-tslint-rules` and
`tslint-no-circular-imports`.
For any custom rules, we can either add them as ESLint rules if possible, or
create an issue for them if not.
After that, you can remove the `tslint-rule` folder and the postinstall
build step (`npm run build:tslint-rules`), and update the `lint` and `lint:fix`
scripts to use ESLint instead.
It seems that `src/tslint.json` should be removed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
