tbonelee commented on code in PR #5109:
URL: https://github.com/apache/zeppelin/pull/5109#discussion_r2455400400
##########
zeppelin-web-angular/projects/zeppelin-sdk/.eslintrc.json:
##########
@@ -0,0 +1,35 @@
+{
+ "extends": "../../.eslintrc.json",
+ "ignorePatterns": ["!**/*"],
+ "overrides": [
+ {
+ "files": ["*.ts"],
+ "parserOptions": {
+ "project": ["projects/zeppelin-sdk/tsconfig.lib.json",
"projects/zeppelin-sdk/tsconfig.spec.json"],
Review Comment:
I set `parserOptions.project` to `true` and unified the per-project config
filenames from `tsconfig.*.json` to `tsconfig.json`. With this,
`@typescript-eslint/parser` automatically picks the nearest `tsconfig.json` for
each file instead of relying on hard-coded project paths, which avoids the
path-resolution error we saw.
If/when we upgrade Angular further and adopt ESLint's flat config, we can
switch to a javascript flat config and keep paths relative to the config file
location using `__dirname`, which should remove this class of issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
