tbonelee commented on code in PR #5309:
URL: https://github.com/apache/zeppelin/pull/5309#discussion_r3597992639
##########
zeppelin-web-angular/src/app/services/completion.service.ts:
##########
@@ -72,8 +71,8 @@ export class CompletionService extends
MessageListenersManager {
that.messageService.completion(id, model.getValue(),
model.getOffsetAt(position));
- return that.completionItem$
- .pipe(
+ return firstValueFrom(
Review Comment:
Non-blocking: you could pass `{ defaultValue: { suggestions: [] } }` as the
second arg here to guard the theoretical empty-stream case (`firstValueFrom`
rejects with `EmptyError` if the source ever completes without emitting). Not
needed for this PR since the `Subject` is never completed, just noting it for
robustness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
