tbonelee commented on code in PR #5309:
URL: https://github.com/apache/zeppelin/pull/5309#discussion_r3597992639
##########
zeppelin-web-angular/src/app/services/completion.service.ts:
##########
@@ -72,8 +71,8 @@ export class CompletionService extends
MessageListenersManager {
that.messageService.completion(id, model.getValue(),
model.getOffsetAt(position));
- return that.completionItem$
- .pipe(
+ return firstValueFrom(
Review Comment:
Non-blocking, and really just answering the question you already raised in
the PR description: agreed that the empty-stream `EmptyError` difference is
only theoretical here, since `completionItem$` is never completed, so I don't
think a `defaultValue` is necessary for this PR. If you'd still prefer the
extra safety net, `firstValueFrom(..., { defaultValue: { suggestions: [] } })`
would cover it, but I'm fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
