voidmatcha opened a new pull request, #5327:
URL: https://github.com/apache/zeppelin/pull/5327

   ### What is this PR for?
   Adds two e2e scenarios missing from the Angular suite and cleans up the 
action bar's personalized-mode toggle found along the way.
   
   - **Collaborative edit sync**: edits in one viewer propagate to a second 
viewer of the same note (same-principal scope).
   - **Editor find widget (per-paragraph Monaco)**: open via shortcut, match 
count and highlights, next/previous navigation, replace-all. The notebook-wide 
search/replace menu is unimplemented and tracked separately by 
[ZEPPELIN-6442](https://issues.apache.org/jira/browse/ZEPPELIN-6442), so its 
scenarios are out of scope here.
   - **Accessibility**: `aria-label` on the two icon-only personalized-mode 
toggle buttons (the only `src/` change).
   - **Test cleanup**: replaces the always-skipped action-bar toggle test (its 
gate targeted a `ng-container[ngSwitch=...]` that never renders) with a real 
toggle round-trip test (auth mode; skipped for anonymous, where the button 
isn't rendered).
   
   Page objects follow `e2e/AGENTS.md` (EditorSearchPage, CollaborationPage; 
shared auth-skip helper in `e2e/utils.ts`).
   
   ### What type of PR is it?
   Improvement
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-6547
   
   ### How should this be tested?
   Ran the collaboration and editor-search specs 10x per mode (anonymous + 
auth) across all browser projects with `--retries=0`, all green:
   https://github.com/voidmatcha/zeppelin/actions/runs/29684367065
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to