dev-donghwan opened a new pull request, #5328: URL: https://github.com/apache/zeppelin/pull/5328
### What is this PR for? `HiveUtils.isProgressBarSupported(String)` decides whether to show the Hive query progress bar by parsing the version returned by `HiveVersionInfo.getVersion()`. The previous implementation split the version on `.` and parsed the first two tokens with `Integer.parseInt` with no validation, so it threw for two version shapes that real Hive builds can produce: - **Missing dot** (e.g. `"2"`): the split yields a single-element array, so reading `tokens[1]` throws `ArrayIndexOutOfBoundsException`. - **Qualifier suffix** (e.g. `"3-cdh"`, `"2.3-dev"`): a numeric segment carries a trailing qualifier, so `Integer.parseInt` throws `NumberFormatException`. Either exception propagates into `startHiveMonitorThread()` and can break Hive job monitoring setup. This PR makes the parser return a boolean for any input without throwing: - strips any qualifier after the numeric version (`"3-cdh"` -> `"3"`, `"2.3-dev"` -> `"2.3"`), - treats a missing minor segment as absent (`"3"` -> major 3 = supported, `"2"` -> major 2 with no minor = not supported), - returns `false` for null / blank / otherwise unparsable versions. The support rule is unchanged (progress bar is supported from Hive 2.3, HIVE-16045); it is only made robust and expressed as explicit tiers: major >= 3 always supported, major <= 1 unsupported, major == 2 depends on minor >= 3. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6479 ### How should this be tested? `./mvnw test -pl jdbc -Dtest=HiveUtilsTest` The new `testIsProgressBarSupported` calls `HiveUtils.isProgressBarSupported` directly — the method is made package-private to match its sibling helpers in the same class (`extractMRJobURL`, `extractTezAppId`), which are already package-private and unit-tested the same way (no reflection). Testing through the only caller (`startHiveMonitorThread`) is not practical because the version is obtained internally from `HiveVersionInfo.getVersion()` and the method needs a live `HiveStatement`, so the edge-case versions cannot be injected. Cases cover the 2.3 boundary, both failure modes, null/blank input, and recent Maven Central releases (Hive 4.2.0 and 4.0.0-beta-1). ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
