Corey - Things picked up and didn't have a chance to follow up. While I haven't had a chance to test it, I've read through the code and it looks good. The only downside is that the knowledge of what RSB components need to be registered, what life cycle the framework expects the components to have (where applicable), etc... now has to be replicated across each of the container implementations, and if anything needs to change, all container implementations will need to change as well. I don't see this as being too much of a problem - a generic suite of tests that can run a comprehensive suite of validation checks is all that would be needed to keep the house in order, IMO. They could just do an assembly scan, pick up the various container implementations, and run each through the gauntlet. What seems to be missing, however, is roles. The Castle config implementation is broken down into a bunch of little IBusConfigurationAware interface implementations, each named according to the constellation of components it configures. While that's great guidance for someone implementing support for another container (i.e. "don't register all your components in one gigantic class") you could probably take it a step further and take those groupings you came up with and extract configuration role interfaces from them - IBusSecurityConfiguration, etc... and then use that to drive the test suite and have a set of assertions about each specific configuration role implementation.
Hopefully I'll have more time to dig into it more in the coming days or next week... Thanks for the hard work, Matt On Tue, Jan 4, 2011 at 7:52 AM, Corey Kaylor <co...@kaylors.net> wrote: > Here it is. Looking forward to any constructive feedback. > https://github.com/hibernating-rhinos/rhino-esb/tree/servicelocator > > -- > You received this message because you are subscribed to the Google Groups > "Rhino Tools Dev" group. > To post to this group, send email to rhino-tools-...@googlegroups.com. > To unsubscribe from this group, send email to > rhino-tools-dev+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rhino-tools-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "Rhino Tools Dev" group. To post to this group, send email to rhino-tools-...@googlegroups.com. To unsubscribe from this group, send email to rhino-tools-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rhino-tools-dev?hl=en.
