* There's no need to add javadoc statements like "See [EMAIL PROTECTED]
TranslatorSupport} interface". Interface methods that are
implemented without javadocs will automatically inherit the
javadocs that have been written in the interface and have a
reference towards them.
What do you mean by reference?
For example: http://rifers.org/docs/api/com/uwyn/rife/authentication/
credentialsmanagers/MemoryUsers.html#verifyCredentials
(com.uwyn.rife.authentication.Credentials)
* Defensive markup encoding
What if is needed some tags as litteral strings, i.e. not to be
interpreted as real tags?
You can still encoding them manually using entities like < and >
Anyway, I think this should better be left for a second stage and
that the l18n is first focused on the dynamic provision of
locales. I would thus not at all create an encoder package, nor
perform the refactorings you did.
* The I18n class
This seems to be too hardcoded and linked to a SpringWeb
participant. I don't like this very much since Spring should
merely be a one possible IoC reference factory.
I put all the Spring dependencies into I18n class. Then it should
be the only part to refactor if an other container is to be used.
Yes, but you reference the I18n class in the engine package, which
means that there's a hard dependency on it and thus on Spring.
There's not injection of the actual locale-related class instances.
I haven't looked at all the interactions, but please try to
leverage the HierarchicalProperties support of RIFE that is
present throughout the whole application (from Rep, to
participants, to elements): http://rifers.org/wiki/ display/RIFE/
IoC+properties+support+inside+the+repository
I did it like this in the continuation of my first proposition
about getLocales.
I'll dive asap in the HierarchicalProperties stuff.
OK to use EngineTemplateInitializer. It was my first attempt ;-) I
don't remember exactly why I changed.
My goal is to get the same behavior with encoder, locales and
bundles for L10N tag in template and a direct call from an element.
Yes indeed, to achieve this using the EngineTemplateInitializer is
the best way imho.
Best regards,
Geert
--
Geert Bevin Uwyn bvba
"Use what you need" Avenue de Scailmont 34
http://www.uwyn.com 7170 Manage
gbevin[remove] at uwyn dot com Tel +32 64 84 80 03
PGP Fingerprint : 4E21 6399 CD9E A384 6619 719A C8F4 D40D 309F D6A9
Public PGP key : available at servers pgp.mit.edu, wwwkeys.pgp.net
_______________________________________________
Rife-users mailing list
[email protected]
http://www.uwyn.com/mailman/listinfo/rife-users
