Geert,
* There's no need to add javadoc statements like "See [EMAIL PROTECTED]
TranslatorSupport} interface". Interface methods that are
implemented without javadocs will automatically inherit the
javadocs that have been written in the interface and have a
reference towards them.
What do you mean by reference?
For example: http://rifers.org/docs/api/com/uwyn/rife/authentication/
credentialsmanagers/MemoryUsers.html#verifyCredentials
(com.uwyn.rife.authentication.Credentials)
In MemoryUsers files, there is no javadocs at all for verifyCredentials.
So all is fully automatic?
* Defensive markup encoding
What if is needed some tags as litteral strings, i.e. not to be
interpreted as real tags?
You can still encoding them manually using entities like < and >
OK. I don't like it too much but at least it's coherent: if someone need
a full tag as a litteral, then this person is supposed knowing how to
preencode it.
Just a last try. What about:
- regexp to detect tag to use as it is
- but only if no escaping at the beginning of the whole tag
Anyway, I think this should better be left for a second stage and
that the l18n is first focused on the dynamic provision of locales.
I would thus not at all create an encoder package, nor perform
the refactorings you did.
* The I18n class
This seems to be too hardcoded and linked to a SpringWeb
participant. I don't like this very much since Spring should
merely be a one possible IoC reference factory.
I put all the Spring dependencies into I18n class. Then it should be
the only part to refactor if an other container is to be used.
Yes, but you reference the I18n class in the engine package, which
means that there's a hard dependency on it and thus on Spring.
OK. But in my first proposition about only locales, there was already
such a dependency (I18n.java was then Locales.java). I don't see why
here it more an issue.
There's not injection of the actual locale-related class instances.
I'm not sure what is the point here. The getLocaleProviderFactory and
getLocaleProvider from the initial Locales class are still present in
the I18n one.
Pierre
_______________________________________________
Rife-users mailing list
[email protected]
http://www.uwyn.com/mailman/listinfo/rife-users
