Robin Bowes;257387 Wrote: 
> quietdragon wrote:
> [color=blue]
> > - I couldn't get the MD5 checksum test to work. After probing I saw
> >   the MP3::Tag appears to return the TXXX tag as "MD5 / n" in the
> >   Description! Huh? I made a corresponding change in the source code
> >   but perhaps the problem is actually elsewhere.
> 
> Strange. Works for me. What exactly do you mean?
> 

I made a small change to the code to print out the tags and content
that it is seeing when trying to compare the MD5 checksum:
Code:
--------------------
    
  my $cfname = $MP3frametexts{$frame};
  my $cfkey  = $Complex_Frame_Keys{$method};
  print STDERR "Frame $frame  cfname $cfname  cfkey $cfkey  tag_info 
$$tag_info{$cfkey}\n";
  if ( $$tag_info{$cfkey} eq $cfname ) {
  $dest_text = $$tag_info{'Text'};
  if ( $frame eq 'MD5' ) {
  $pflags{md5} = 0 unless
  ( $frames_to_update{'MD5'} ne $dest_text );
  
--------------------


I now run this on a test case using --debug for greater effect, and
gather the output:
Code:
--------------------
    
  frame is 'MD5'
  method is 'TXXX'
  values from id3v2 tags:
  $VAR1 = \'User defined text information frame';
  $VAR2 = [
  {
  'Description' => 'MD5 / 0ab9c991bb971e0c72646037162fa0c2',
  'Text' => '',
  'encoding' => 3
  }
  ];
  
  Frame MD5  cfname MD5  cfkey Description  tag_info MD5 / 
0ab9c991bb971e0c7264603
  7162fa0c2
  $dest_text: $VAR1 = '';
  
--------------------


Notice the structure of the tag_info. The checksum appears in the
Description, not in the Text!


-- 
quietdragon
------------------------------------------------------------------------
quietdragon's Profile: http://forums.slimdevices.com/member.php?userid=10412
View this thread: http://forums.slimdevices.com/showthread.php?t=42088

_______________________________________________
ripping mailing list
[email protected]
http://lists.slimdevices.com/lists/listinfo/ripping

Reply via email to