Updates:
Summary: Support for Python standard `logging` module
Status: Accepted
Comment #10 on issue 455 by pekka.klarck: Support for Python standard
`logging` module
http://code.google.com/p/robotframework/issues/detail?id=455
I finally had time to look at this in more detail, and I'm starting to be
convinced
the proposed enhancements make sense. This would have been too big change
for RF
2.1.3, but getting this into 2.5 is possible if you Chris (and/or others)
are willing
to help.
See my comments below for changes/tasks needed before these features can be
incorporated. The comments below are in no particular order.
1) As a general comment, it would be better to include a patch instead of a
full
file. Patches are easier to review and changes to the files in question
after
creating the patch aren't that likely to cause problems.
2) There are too many issues bundled into one. There should be separate
issues and
patches for the logging module support, handling timestamps correctly, and
integrating stdout and stderr better. This makes reviewing easier, allows
incorporating features one-by-one, and all these enhancements are then also
shown in
the release notes separately.
3) RF 2.5 has Python/Jython as the minimum required version so the logging
module is
always available and no `try/except ImportError`s are needed anymore.
4) Adding the timestamp to messages in format {{TIME:<timestamp>}} and then
reading
it later feels somewhat fragile and ugly. Could we split the messages
written to the
stdout/stderr into Message objects immediately and get the timestamp for
free? This
might require a bigger refactoring but I'm not afraid of that if it makes
the code
better. Anyway, handling timestamps should be discussed in a separate issue
(there's
already issue 456) and have a separate patch.
5) All the new features/enhancements need to have either unit or acceptance
tests (or
both). Adding new acceptance tests might be a bit tricky if you don't know
our atest
system, but the core team can help with it.
6) The support for the logging module needs to be documented in the User
Guide. Other
enhancements are more actually more like bug fixes and I don't think they
need extra
documentation.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
