Comment #10 on issue 854 by pekka.klarck: Regular expression support for embedded argument syntax
http://code.google.com/p/robotframework/issues/detail?id=854

Great that you've already started and really nice that you have already done some tests. The test you've done should be on the test data side (atest/testdata/keywords/embedded_arguments.txt), though, and on the robot side (atest/testdata/keywords/embedded_arguments.txt) you should verify that the executed tests worked as expected. See other tests there and atest/README.txt for more details.

I looked at the implementation briefly and you are definitely on a right track but making it slightly more complicated than it needs to be. There's, AFAIK, no need for VariableSplitter to know about the possible regexps (which is good because code there is somewhat cryptic). Instead EmbeddedArgsTemplate could handle splitting the regexp from the base of the variable itself.

I got some prototype code that seems to work done and could fairly easily clean it up and create tests so that I could commit it. I wouldn't mind spreading the knowledge on how to add tests etc. and could thus also help you getting this done. Let me know if you have time and are interested. Otherwise I think I'll do this latest on Monday so that we get the issue done before the next 2.6 preview release.

Reply via email to