> -----Original Message----- > From: Janosch Machowinski [mailto:[email protected]] > Sent: Freitag, 24. Januar 2014 17:01 > To: Raul Dominguez; Sylvain Joyeux; Thomas Röhr; Jakob Schwendner; > Alexander Duda; Benjamin Girault > Subject: Re: Tilt Scan component > > +1 > On 24.01.2014 17:00, Raul Dominguez wrote: > > Hello Rock developers, > > > > I include in this email all those who had made any commit to the > > tilt_scan task. > > > > In VirGo4 we are using the tilt_scan without for sometime now without > > issues. > > > > Maybe it should be merged to next? In principle I would agree. However, I have some issues with some of the later commits: - the component requires a position feedback loop. If it's not there, it doesn't run, even though it did function open loop before. - Its now got a property to enable/disable point cloud generation. Imho it would be much nicer to leave out these kinds of properties, and use outputPort.connected() there to find out if we should generate a certain output data of the module.
I guess though it would still be ok to move it to next. Cheers, Jakob _______________________________________________ Rock-dev mailing list [email protected] http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
