ok, i finally got around to looking at this a little bit last week and
the following is my review. My general feeling is that the
implementation is not complete and needs some more work before I would
be ready to commit it to the trunk. My reasons are ...
1. The data model is very simple and doesn't include anything from the
discussions we had with David Levy on the mailing list. It's still
possible that we want to keep the data model this way, but I have not
made my own decision about that yet and I think it needs more discussion.
2. The backend code added to the WeblogManager doesn't look great. I
don't like that some of the methods return things like Object[] arrays
rather than processing that data and putting it into a more intuitive
Object. Some methods only partially implement what the method suggests
it does.
3. There is no consideration put towards using tags in xml feeds. This
may be a good thing at first, but in the original proposal we talked
about having xml feeds based on tags, so I expect something.
4. There is no consideration for performance or caching. Personally, I
would like to at least see some kind of documentation about how the
implementation plans to maintain good performance. If we haven't even
thought about that then we have a problem.
5. The UI isn't exactly well done. The tags page doesn't have its own
tab, so it looks weird when you are on the tags page and have the Main
and Planet tabs showing. And I don't believe the UI had any way to
constrain the tags view to a specific weblog.
6. No configuration options. There is no easy way to enable/disable
tagging support like we discussed and there are no controls for how the
tagging support will work if it is enabled. I think considerations like
items per page, max tag combinations allowed, etc are worth making
controllable.
So, i think this is a step in the right direction, but i would like to
see things flushed out a bit more before we commit them to the trunk. i
would also like to continue a bit more of our discussion on the tagging
data model because i think that is the most crucial piece of the puzzle
for tagging.
-- Allen
- Evalutating tag support Allen Gilliland
-
