Anil Gangolli wrote:

Is this worth submitting as a patch?

I think it's fine as long as the behavior in the case the property is not set is the same as current behavior.
Right. So I'd put the new property commented out in roller.properties. The recommended way to activate it would be to uncomment it and set the right locale in roller-custom.properties.

Just file an improvement request with or without a patch diff and let me know the bug # or assign it to me if you can. I'll get around to it before 2.1 goes out. It's a pretty small change.
Cool.  We should be able to submit a patch early next week.


I'd love to see dynamic locale setting, but can't commit to

I'll propose something later. I don't really know what's involved in doing this right, and I'd have to play around.
We have some experience with this in a Turbine-based app, but not idea where to start with Roller, but we'd really love to see this feature and could at least provide good testing and feedback (and maybe a patch or two when we find a bug ;)

-- Sean

Reply via email to