On Feb 28, 2006, at 11:45 PM, Allen Gilliland wrote:
I have been going through some of the Roller backend and looking at
some
parts of our Hibernate implementation and I have gotten myself to
wondering if we really need the transaction methods begin() and
commit()
which are part of the Roller and PersistenceStrategy interfaces.
I think I understand where the idea for these methods came from and
they
make some sense, but after inspecting the code a bit it seems like we
definitely don't actually use them.
In the current code I only see this ...
Roller.begin() - 6 uses
Roller.begin(user) - 4 uses
Roller.commit() - 7 uses
Roller.rollback() - 0 uses
PersistenceStrategy.begin() - 4 uses, just from RollerImpl classes
PersistenceStrategy.commit() - 4 uses, mainly RollerImpl classes
Where are you getting that data? Netbeans reports 159 usages of
Roller.commit() and 17 usages of Roller.rollback().
I also noticed that in our Hibernate implementation we aren't actually
using Transactions anyways, so even if these methods were in full
use we
wouldn't have been taking advantage of them.
So, the deal is that if we want to use these transaction methods
then we
need to make sure we are using them *everywhere*, otherwise they are
doing us no good and only confusing things. Alternatively I would
propose that we drop these methods and let implementors of a
persistence
strategy handle the details of transactions within their own
implementations.
My vote is to drop these methods. I can see the potential value in
having them (if they were working properly), but my opinion is that we
aren't really doing any persistence transactions complicated enough to
really warrant the additional complexity and overhead of having them.
We have to go one way or the other, so we either remove them or add
them
in everywhere.
Who else has an opinion?
I feel pretty strongly that we need to follow that very simple and easy
to follow pattern, keep the transaction methods and make sure they
work properly. There are definitely situations where we want to be
atomic.
Roller was originally developed with a database that didn't support
referential integrity or transactions, but I still tried to do the
right thing
so that, at some point in the future it would be easy to move to a
database
that did support those things.
I vote that we turn on transaction support in Hibernate and make sure
those begin(), commit() and rollback() methods are working properly.
- Dave
-- Allen
