Dave Johnson wrote:
On 6/21/06, Allen Gilliland <[EMAIL PROTECTED]> wrote:
Dave Johnson wrote:
> We've got the optimization in place now with 2.0. Plugins are
> initialiazed upfront.
Huh? How? My understanding is that currently the PageHelper class
initializes the plugins when it is instantiated and the PageHelper is
constructed once each time the ContextLoader.setupContext() is called.
It doesn't make sense to me that we could have plugins initialized
upfront in 2.0 because the problem is still the same. Each set of
plugins has to be customized per weblog.
the plugins get initialzied when the ContextLoader sets up the
context, not everytime that an entry must be rendered.
got it. it probably makes the most sense that the plugins are tied to
the WebsiteData pojo. i'm not sure if we can store the inited plugins
in the WebsiteData object though, so you'd have to test that out to see
if it's possible. if not then i think we'd have to look at caching that
stuff in the PluginManager.
>> > For #2, I think we should change plugins so that they do NOT add
things
>> > to the context , since the mechanism for adding things to context
is to
>> > use page models.
>>
>> I agree, the only plugin that I know this affects is the TextilePlugin
>> and it doesn't look like it will make the plugin break.
>
> The Wiki plugin, one of my faves, will be broken. But I will fix it to
> support 3.0 by using the page model approach.
Ah, yeah, that does suck. That one's not in the Roller codebase so I
didn't know about it.
What is the plan for fixing it via page models? Not have it considered
a plugin, instead have it be a custom page model?
I think the Wiki plugin must be a plugin + a page model.
i'm still uncertain of what that means, how are the two tied together?
why does the wiki plugin need to put things in the context anyways?
-- Allen
- Dave
