How much slower is method 1?
I'd go for method #1 and permit large installations to do #2 is the time
gained is worth it. (I can't believe it would be in most cases).
Allen Gilliland wrote:
Dave Johnson wrote:
Comments below...
On 8/31/06, Allen Gilliland <[EMAIL PROTECTED]> wrote:
I think I brought this up during the 2.0 release, but the situation has
happened again. There is a bit of semi-complex sql which needs to be
executed as part of the 3.0 database upgrade sequence and I'm unsure of
what our ideal approach should be.
so, the question is, in this scenario how do we want to handle this?
there are 2 options ...
1. use our standard UpgradeDatabase class and do the operation in a
generic sql fashion that would work on all databases? the benefit is
that it's a single method that works on all dbs, the drawback is that
it's slow. the method to do this would require doing a couple queries
to fetch the set of website locales and entries first, then iterate
over
the entries and do a sql update for each one.
2. use a database specific sql statement to do the job? the benefit is
speed, and the drawback is that we then need to figure out this
statement for each db we support and put it in the specific db scripts.
either way works, but i suppose #1 is potentially less painful. also
take into consideration that the occurrence of these situations is
limited and most likely only happens for major releases. presumably if
we have someone on the list actually testing on each db then it should
be fairly easy to get a variant of the statement for each db pretty
quickly.
thoughts? opinions?
I guess I like to keep things easy for the installer and most folks
probably have fairly small Roller installs.
I agree and that's why I am leaning towards the option #1.
I wonder, can we have both ways, i.e. can large sites choose to run
the speedy database specific SQL before starting Roller, but smaller
sites can choose to let the slow DatabaseUpgrade class do the work?
Yes, that is possible so long as the person doing the upgrade does all
the necessary sql work and then manually sets the dbversion property
to the new version. That's how we have done this in the past on
blogs.sun.com.
It takes a bit of extra knowledge, but if you are running a large
Roller installation and need to think about these things then it
should be that hard to understand.
-- Allen
- Dave
--
Dave
<http://www.sun.com> * David Levy *
*Sun Microsystems Ltd.*
55, King William St.,
London EC4R 9ND United Kingdom
Phone +44 (0) 20 7469 9908/x18308
Mobile +44 (0) 7710-360922
Blog http://blogs.sun.com/DaveLevy
Email [EMAIL PROTECTED]
Sun Proprietary & Confidential . This e-mail message is for the sole use
of the intended recipient(s) and may contain confidential and
privilidged information. Any unauthorised review, use, disclosure or
distribution is prohibited. If you are not the intended recepient,
please contact the sender by reply e-mail and destroy all copies of the
original message.
