Elias Torres wrote:
I think I'm getting out of this tagging slump I was in and made more progress on tagging. I've moved the WeblogManager code to use the aggregate table now and everything is working fine. For now, I've decided to go with the getAddedTags() and getRemovedTags() approach and use the saveWeblogEntry and removeWeblogEntry methods in WeblogManager. The idea behind this is that hopefully anybody manipulating a WeblogEntryData POJO won't have to worry about maintaining the aggregate table.
good to hear.
I've also added 2 macros to weblog.vm: #showTagCloud($tags) and #showEntryTags($entry). The first will get tags from the respective model (getTags() or getHotTags(limit). The second will display tag links for technorati to crawl.
I think we need to be careful about these macros. For Roller 3.0 we explicitly designed the new set of macros to only include things that are truly generic and reusable, and to make sure that any macros that we provide do as little formatting as possible. We want to get out of the business of providing large and complex macros which are both hard to maintain and ultimately hard to customize.
The #showTagCloud() macro is slightly leaning toward the path of being too complex in my mind, and things that are not going work is including those "center" tags and hardcoding the min & max values. I also think that a tag cloud is not necessarily the kind of thing that we expect to go on every weblog, so I don't think it would be bad if we expect users to do this work in their templates if they really want it.
The #showEntryTags() macro is fairly reasonable, but in my opinion is probably so simple that we may be better off forcing users to do that one as well. The one thing you can't do is put the "Tags: " line in there, because that's not i18ned and we would much rather just not put any text in the macros moving forward. In any case, I don't think it's a big deal to ask users to do as simple for loop in their templates and that way they can create their own <a> html rather than relying on ours which would have its own styling conventions.
-- Allen
I've also added support for filtering entries based on tags on the edit UI and <drumroll/> ... I've tested tagging with unicode characters and everything worked beautifully (once I made sure my db was utf-8). Anyways, based on feedback, my next thing will be auto-complete servlet which now should be very straight-forward. -Elias
