Elias,
I am just going through the latest code now and wanted to point out a
few things that I came across ...
1. Feeds by tags are not working, i just get the normal feed.
2. In WeblogFeedRequest I think we want to ensure that the criteria
specified is tags *or* category, but not both. So if someone happens to
specify both in the url then we should catch that and throw an
InvalidRequestException.
3. In WeblogPageRequest I think we should do the same thing as #2 and
only allow the /weblog/tags/etc+etc urls. So you don't need to check
for a "tags" request parameter because we won't allow viewing pages
constrained by tags & date & category all at the same time.
4. I think the cache key generation for everything needs to account for
the restrictions of #3 and #4. So like it works in WeblogPageCache now,
if a specific entry is specified then all other criteria are ignored, we
should do the same for tags.
5. I think it would be wise to set some kind of limit on the number of
tags that can be intersected at a time. This could be something that is
a configuration option that the site admin sets, but i think this is a
good way to help large sites keep their tagging urls from getting out of
control. So we would set the limit to say, 3, and that means that you
could get a page with tags=foo+bar+yay but not tags=foo+bar+yay+yo. If
a url specifies too many tags then that's an invalid url.
I think that's it.
-- Allen
