Elias Torres wrote:
Allen Gilliland wrote:
we need to make a decision on the macros issue. comments below ...
Dave wrote:
On 10/23/06, Allen Gilliland <[EMAIL PROTECTED]> wrote:
One more thing I think we forgot about a while back is what to do about
macros. I am still of the opinion that we need to be very careful about
anything that gets exposed to users (Models & Macros) because those are
the things we have to support long term and may not be able to change.
I haven't played with the 2 new tag macros, but should probably review
them and make sure they are what we want.
The two macros are very simple, so simple in fact I wonder if we
should include them. It might be a better idea to show some examples
of how to display tags and then see what folks come up with as they
try to use them on their blogs.
I've used the tags. Here are some more comments.
The tag-cloud macro does pretty much what I want it to do. Since you
pass in the tags, you can control the number displayed. Since the
intensity is part of the CSS class you can size/color/style the tags
how you want.
Are there other parameters folks might want to use?
Should we use a <ul> list to allow even more creative styling?
#macro(showTagCloud $tags)
#foreach ($tag in $tags)
<a class="tag s${tag.intensity}" href="$url.tag($tag.name)"
title="$tag.count">$tag.name</a>
#end #end
IMO, this one probably should be ditched and we can provide an example
of how to do it but not a macro. I just think that it's easy enough to
do and something that is likely enough to want to be styled/customized
to fit the users liking that we should just let users deal with this
one. I also don't think this is something that should automatically go
on all weblogs, so I think there are lots of people who won't need to
use a tag cloud and thus we don't need to support it as a built-in macro.
I'm fine either way.
I've been thinking about it a bit more and I am fairly settled on
removing the tag cloud macro. I don't think it needs to be there and
it's certainly simple enough that users who really want to do it can
accomplish it without much trouble.
I'm going to go ahead and remove it.
The entry tags macro is simple too. Its just a list of tags, each
linking to the tag a specific view. That's generally useful, but I was
thinking of having my tags link to Technorati and it won't work for
that. Also, it should probably be named #showWeblogEntryTags().
#macro(showEntryTags $entry)
#set ( $tags = $entry.tags )
#foreach($tag in $tags)
<a href="$url.tag($tag.name)" title="$tag.count"
rel="tag">$tag.name</a>
#end
#end
I am on the fence here. I am okay with this being a macro because I
think that many people will want to use it, but it's also so simple that
I don't mind telling people to do it themselves.
Also on the fence. I just put them there so you guys can see them.
Since we need a decision here I'll say let's just leave it. I think
it's a generic enough macro that we won't run into maintenance problems
and it's useful enough that I think users will likely appreciate having
it. I do want to make one change though, I'm going to swap out that
for a normal space because I think that it's preferable if
someone with a lot of tags and a narrow entry display layout has their
tag list wrap to the next line rather than continue off the side of the
page.
I'll commit these changes in a minute.
-- Allen
One other item. The WeblogTagData should have get/setWeblog() not
get/setWebsite() -- we're trying to replace Website with Weblog in the
code and docs.
definitely agreed.
me three.
-- Allen
- Dave
PS. I'm working on 3.1 docs today, so I'd like to resolve these issues
ASAP.
