good point. we probably fixed the actual generated SQL file, but the next time the file is generated, the error pops up again.

so the file metadata/database/control.vm needs to be changed.
lines 34-35, from

#elseif ($DBTYPE == "ORACLE")
alter table $table add column $column $type default $default not null;

to

#elseif ($DBTYPE == "ORACLE")
alter table $table add $column $type default $default not null;


should do the trick. if someone can change this, then send me the generated files, I'll have a check to see that they're okay.

B


Henri Yandell wrote:
Looking at the source quickly - I'm guessing the problem is that the
scripts are generated and there's no concept for 'ignore the keyword
column' currently.

Hen

On 11/9/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
clearly not. i downloaded the 3.0 app 4 hours ago!

James Nott
Senior Developer, BioMed Central
Email: [EMAIL PROTECTED]
Direct Tel: 020 7631 9933


-----Original Message-----
From: Ben Avery [mailto:[EMAIL PROTECTED]
Sent: 09 November 2006 16:47
To: [email protected]
Subject: Re: Oracle scripts


I believe I flagged this up quite a few weeks ago. has it not been
changed yet?



[EMAIL PROTECTED] wrote:
> The oracle upgrade script is wrong.
>
> alter table website add column lastmodified timestamp default null;
>
> should read
>
> alter table website add lastmodified timestamp default null;
>
> ie no key word "column"
>
> this keyword is in other upgrade scripts.
>
> James
>
>
>
> James Nott
> Senior Developer, BioMed Central
> Email: [EMAIL PROTECTED]
> Direct Tel: 020 7631 9933
>
>

--


Ben Avery
Software Developer
Youthnet UK

email: [EMAIL PROTECTED]
phone: 020 7288 7333
snail: 2-3 Upper Street
        London N1 0PQ


--


Ben Avery
Software Developer
Youthnet UK

email: [EMAIL PROTECTED]
phone: 020 7288 7333
snail: 2-3 Upper Street
       London N1 0PQ

Reply via email to