No objections, but some confusion on my part as to the plan moving forward.
What happened to the suggestion to do the work on a dev branch? Wouldn't
that address this as well? It seems like we are seeing yet another instance
of sandbox not being as flexible as branch.
--a.
----- Original Message -----
From: "Dave" <[EMAIL PROTECTED]>
To: <[email protected]>
Cc: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Wednesday, January 24, 2007 8:03 AM
Subject: Roller JPA backend status
We've now got the Roller JPA implementation in the sandbox passing
100% of the JUnit "business" tests and I'm able to run the Roller Web
UI via JPA now.
However, there still couple of issues/problems:
1) Currently, not configured via JNDI datasource but instead by property
file.
2) Need schema change for weblogcategory table to allow websiteid to be
null
and I'm reluctant to put commit this change into the Roller schema as
websiteid
is required for categories.
3) Separation of Planet code in apps/planet makes running Planet tests
against
the JPA backend difficult so I haven't run the PlanetManagerTest yet.
4) The Roller UI comes up but sanity testing revealed these problems:
- Weblog edit: Missing categories in weblog edit page
- Comment mgmt: Marking comment as spam fails
- Categories: remvoing category throws exception
- Planet config: access config page throws exception
5) There are a number of TODO markers in the implementation that concern
me,
especially the ones that say "TODO: handle offset and length".
I'll keep testing and debugging items from #4. As I do that I'll add
new tests because those failures almost certainly indicate that we
don't have good enough test coverage.
To address item #3 I'd like to move the JPA/JDO code from the sandbox
and into the apps/planet/src directories.
Allen has two concerns about that move: 1) putting JPA/JDO
implementation under source will require developers to support two
backends and 2) putting JPA/JDO implementation under source implies
that we support JPA/JDO. To address those concerns, I'll change the
build process so that it specifically excludes the JPA/JDO code --
that way, those not interested in JPA/JDO can ignore the code and
since it's not distributed in Roller -- there's no question that we do
not support it.
Anybody have other objections to moving JPA/JDO code out of the sandbox?
Craig and Mitesh: Any comments/suggestions on the other items #1, #2 and
#5?
- Dave
