You really need to start trying to understand what the code you're
changing is doing before just blindly doing it.

> - if ( to->desc == NULL || to->position < min_pos )
> + if( !to->desc || to->position < min_pos )

What's the easy fix to this particular problem?  Don't touch anything.

If you'll actually look at what this is changing, you'll notice
that it is changing nothing.  nada.  zilch.

'to->desc == NULL' is exactly the same as '!to->desc'.


Dennis



On Tue, 9 Jul 2002, Dantin wrote:

> if ( to->desc == NULL || to->position < min_pos )
>              continue;
>
> Here was the original Rom 2.4b6 code before I added OLC 2.01.
>
> Here is the code after OLC 2.01:
>
>  if( (!IS_NPC(to) && to->desc == NULL )
>  ||   ( IS_NPC(to) && !HAS_TRIGGER(to, TRIG_ACT) )
>  ||    to->position < min_pos )
>             continue;
>
> Here is what Lopes color 2.0 wants to do:
>
> - if ( to->desc == NULL || to->position < min_pos )
> + if( !to->desc || to->position < min_pos )
>
>      What I'm trying to do is implement Lopes addition to what OLC has
> already changed without compromising the code. This is the most confusing
> part of the code that I'm trying to fix. Please help.
>
>                                  Dantin




Reply via email to