I guess I'll weigh in here... Personally I prefer Intel syntax, but that alone is not a good reason to keep it Intel. However, I have spent many hours (measured in man-months actually) testing, debugging, and stepping through this boot sector code (both on real hardware and simulators/emulators) to make sure it behaves properly, and I also have not heard of a bug against it in years and years. I would expect any person changing this code to spend the time to make sure it is correct.
So, while I am not against changing it to use a new syntax, I don't think it's a good idea to do that just for the sake of style or because somebody felt like a rewrite. If there was a good reason for change, then that's another story. So unless there are bugs that need fixing, or features that need to be added, I would say that this is one piece of code that should probably not be touched, IMHO. Regards, -Brian -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Timo Kreuzer Sent: Thursday, September 02, 2010 6:37 PM To: ReactOS Development List Subject: Re: [ros-dev] [ros-diffs] [akhaldi] 48687: [FREELDR] - Convert fat12/16 boot sector helper code to gas syntax. Brought to you by the Arty. [CMAKE] - Add freeldr and setupldr to build. Alex Ionescu wrote: > This is retarded, That's your opinion. > Why did this require rewriting everything in AT&T syntax and introducing bugs? It doesn't. Noone said it does. > And what's up with calling AT&T syntax "GAS" Syntax. > Yes, what's up with that? > I wonder what Brian would say.... > Why don't you ask him and report back to us? > It's funny how this project gets rid of old developers, gets new > developers, and has them make the same mistakes/idiotic things the old > developers left for in the first place... > Did you leave for AT&T syntax? Too bad. Anyway, that kinda forces them to find new reasons to leave, doesn't it? That's innovation! Regards, Timo _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev
