Guillaume Laurent wrote:
> you forgot to take care of the size of 
> the mmapped file, so you're memcpy()ing N times more data on it.

I certainly didn't forget.  There is code in SegmentMmapper::refresh
to handle that.  It may be wrong or in the wrong place, but I didn't
forget to write it.

> I disabled it for the moment rather than fixing it because I have concerns 
> about this implementation of repeat segments. It has two limitations : it 
> can't handle infinite loops

No such thing.  A repeating segment always ends at the composition's
end marker time.

> and a change in the segment has to be updated on 
> all the copies.

Yes, it's certainly slower.  I thought it was probably better to do
it this way (because it's so simple) unless and until it's shown to
be too slow, but if you have a better way, go ahead.  I can't complain
too much, since evidently I got it wrong anyway.


Chris



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to