Guillaume Laurent wrote:
> William wrote:
>> The attached patch is my solution. It may do what you're looking for.
>> The drawback, if that is what it is, is in not following
>> the one true path in KDE.
>
> This patch has several issues :
>
> - it hardcodes the default path to the demo files
No, my patch uses the default path as given by the "Initial Directory" setting
which should be set up during installation of Rosegarden's autoload.rg.
That part is not hard-coded; it's part of the autoload configuration.
The only "hardcoded" part is the value of the default field in the
call to config->readEntry() which would be used only in the event
there is no "Initial Directory" setting. One could alternatively
use the location set up by the RG autoconf scripts.
> - it breaks the consistency between the 'open file' dialog which doesn't use
> the 'ROSEGARDEN' keyword and all other dialogs ('save' for instance) which
> still use it.
The behaviour of my patch is identical to the previous behaviour with the
ROSEGARDEN keyword except that the filter now remembers, highly desirably in
my opinion, your previous choice of filter, and also in the case
that there are three or more mimetypes the filter shows "All files" instead
of "All Supported Files" (KDE has class-protected the filter widget).
It would be trivial to change all the other dialogs to have the same behaviour.
In fact I will do that now in my patched RG.
> - it does other unrelated things
It also fixes two deprecated calls to url.isMalformed().
> (checking the number of segments in the doc
> prior to saving it ?)
That check is there because if there are no segments, I don't want to be asked
every time I open a new document whether I want to quit without having saved
the (non-existent) composition.
> And again, I much prefer the idea of having a seperate 'Open demos|samples|
> whatever' menu item.
The menus already have too many items.
William
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
