Stephen Torri: > Let me know if there is a better way to send a patch. Well, the best thing in the long run is probably to give you access to commit to an experimental branch in CVS.
I haven't actually had time to try this yet, only to look, so that places me in an excellent position to make some uninformed comments: - I'm troubled by the addition of new classes named Chord, Note, and Bar. We already have the former two in the Rosegarden namespace with well-understood meanings (Chord is in Sets.h, Note in NotationTypes.h). I don't think we have Bar already per se, but the word is widely used in the code. I'm not even quite sure what is meant by Bar in the context of guitar chords. - I'm assuming the code in guitar/ is yours and tabtrack comes from elsewhere? Where? - KGuitar, NoteEdit? It looks like it does a number of things RG's notation code does elsewhere, and perhaps is "awaiting integration", but I might be misunderstanding. - Our usual naming style is likeThis or m_likeThis for local or class scoped variables, LikeThis for class scoped enum members and constants, LIKE_THIS for global or namespaced constants only (with a few dubious exceptions, of course). - Is the XML usage strongly bound to libxml? Just because we obviously already use the Qt XML parser elsewhere. - The patch contains a few spurious bits, including diffs to moc-generated files and diffs for the KDE warnings that we provisionally decided not to include yet (or did we? Anyone?) Chris ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
