On Thursday 08 Dec 2005 07:52, D. Michael 'Silvan' McIntyre wrote: > On Wednesday 07 December 2005 06:52 pm, [EMAIL PROTECTED] wrote: > > sections about shift and ctrl actions. I am not a programmer but I think > > that there is a possibility to change the code in rosegardengui.cpp (line > > 4195) > > a blank line > > > to look like that in editview.cpp (line 1461). I know you are smarter > > another blank line
For reference, the equivalent lines in current CVS are 4624 (in rosegardengui.cpp) and 1486 (in editview.cpp). I think that, although these two bits of code look different, they do actually have the same logic. I'd appreciate something a bit more concrete about what exactly the problem is (please indulge me here and assume I missed the original discussion). We do have a fundamental problem with Shift and Control key handling -- we shouldn't really be basing anything on trapping the key press and release events themselves in a given window, but instead should be testing the key status when an associated mouse event happens. Problems that arise from this include: * If the Shift key is pressed when you open an editor window (e.g. because you double-clicked with Shift pressed in order to open a multiple segment selection), then the Shift release event will be received by that editor window and not by the main window -- which will subsequently think you still have Shift pressed, up until the next time you press and release it in the main window. * If the Shift key is pressed when keyboard focus is on another window, but followed by a mouse action in the main window, the mouse action will be treated as if Shift was not pressed. For example, focus on an editor window and then attempt to Shift-drag on the loop ruler in the main window (without explicitly refocusing on the main window first) to set a loop. It doesn't work, because the Shift press event went to the editor, not the main window. If this is the extent of the problems being discussed, then I think it's safe to say we know about them, and we really ought to be fixing them. If we're talking about something else or something more substantial, then that's probably a quite different matter. Chris ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
